Fix hostname None (#2893)

archlinux · Nov 20, 2024 · 3453816 · 3453816
1 parent f827851
commit 3453816
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/archinstall/lib/installer.py b/archinstall/lib/installer.py
@@ -821,7 +821,7 @@ def minimal_installation(
 		testing: bool = False,
 		multilib: bool = False,
 		mkinitcpio: bool = True,
-		hostname: str = 'archinstall',
+		hostname: str | None = None,
 		locale_config: LocaleConfiguration = LocaleConfiguration.default()
 	):
 		if self._disk_config.lvm_config:
@@ -874,7 +874,9 @@ def minimal_installation(
 		# os.remove(f'{self.target}/etc/localtime')
 		# sys_command(f'/usr/bin/arch-chroot {self.target} ln -s /usr/share/zoneinfo/{localtime} /etc/localtime')
 		# sys_command('/usr/bin/arch-chroot /mnt hwclock --hctosys --localtime')
-		self.set_hostname(hostname)
+		if hostname:
+			self.set_hostname(hostname)
+
 		self.set_locale(locale_config)
 		self.set_keyboard_language(locale_config.kb_layout)
 

diff --git a/archinstall/scripts/guided.py b/archinstall/scripts/guided.py
@@ -73,7 +73,7 @@ def perform_installation(mountpoint: Path) -> None:
 			testing=enable_testing,
 			multilib=enable_multilib,
 			mkinitcpio=run_mkinitcpio,
-			hostname=archinstall.arguments.get('hostname', 'archlinux'),
+			hostname=archinstall.arguments.get('hostname'),
 			locale_config=locale_config
 		)