-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Galen consultations prj 27 add ref number wkflw step #4905
Merged
robgaston
merged 20 commits into
master
from
galen_consultations-prj_27_add_ref_number_wkflw_step
Jun 14, 2019
Merged
Galen consultations prj 27 add ref number wkflw step #4905
robgaston
merged 20 commits into
master
from
galen_consultations-prj_27_add_ref_number_wkflw_step
Jun 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jun 13, 2019
arches/app/media/js/views/components/workflows/new-multi-tile-step.js
Outdated
Show resolved
Hide resolved
arches/app/media/js/views/components/workflows/new-multi-tile-step.js
Outdated
Show resolved
Hide resolved
arches/app/media/js/views/components/workflows/new-multi-tile-step.js
Outdated
Show resolved
Hide resolved
this will probably throw a require.js error if it's merged without the companion branch: #4905 |
@whatisgalen can you please remove the many _.DS_Store files added here? we don't want them in the repo and they make it more difficult to review the actual functional changes in this PR. Thanks! |
robgaston
reviewed
Jun 14, 2019
robgaston
reviewed
Jun 14, 2019
robgaston
reviewed
Jun 14, 2019
robgaston
reviewed
Jun 14, 2019
stickler-ci
reviewed
Jun 14, 2019
arches/app/media/js/views/components/workflows/new-multi-tile-step.js
Outdated
Show resolved
Hide resolved
…-prj_27_add_ref_number_wkflw_step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Adds a new step type for workflows allowing multiple tiles to be saved during that workflow step
Ticket Background
See PR in consultations-prj: archesproject/arches-her#54
Original ticket: archesproject/arches-her#27
Further comments
While the scope of the ticket did not explicitly state the need for a generic, multi-tile workflow step, using the mockups it was clear that this is what was required given that other steps would likely need to make use of handling multiple tiles.