Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reference Numbers workflow step #27

Closed
chiatt opened this issue May 1, 2019 · 7 comments
Closed

Add Reference Numbers workflow step #27

chiatt opened this issue May 1, 2019 · 7 comments

Comments

@chiatt
Copy link
Member

chiatt commented May 1, 2019

Screen Shot 2019-05-01 at 4.18.52 PM.png

Screen Shot 2019-05-01 at 4 21 53 PM

@chiatt chiatt mentioned this issue May 2, 2019
7 tasks
@whatisgalen whatisgalen self-assigned this May 21, 2019
whatisgalen added a commit that referenced this issue Jun 11, 2019
whatisgalen added a commit that referenced this issue Jun 11, 2019
whatisgalen added a commit that referenced this issue Jun 13, 2019
whatisgalen added a commit that referenced this issue Jun 13, 2019
@robgaston robgaston assigned chiatt and unassigned whatisgalen Jun 14, 2019
@robgaston
Copy link
Member

@chiatt I've reviewed the code here and assigned to you for a functional QA - thanks!

@chiatt
Copy link
Member Author

chiatt commented Jul 9, 2019

This looks really good and is very close to done. There is an issue with values persisting when a reference number is removed from the list on the right: http://recordit.co/ubnJo4ychh
Also - the css could be a bit closer to the mockup. The right side of the title, 'Add Reference Number' is flush with the outside container rather than positioned over the card and the list of instances on the right should probably be in a somewhat darker panel.

@whatisgalen
Copy link
Member

Assigned @dwuthrich to approve UI, @chiatt to approve the viewmodel and template changes.

@whatisgalen
Copy link
Member

Following up on a conversation between myself, @robgaston and @dwuthrich , this step still needs some work in the way of two distinct buttons to add new tiles and proceed to the next step. Right now "Add" adds only one tile and then proceeds to the next step, and then the user has to click the "back" arrow in order to add more tiles. This issue almost certainly extends beyond the scope of just this step and affects any step where the user adds multiple tiles from the same card. Therefore I'm making a new issue to address such a general case.

@dwuthrich
Copy link
Contributor

This step still needs work. When initially encountered, there is no UI that alerts user that multiple tiles can be created. When returning to this card in an active workflow (e.g.: going back to this step), there is no indication of how to move past this step: https://recordit.co/fuJ9OrdxHI

@whatisgalen
Copy link
Member

just merged in some changes, requesting feedback for QA @dwuthrich

@dwuthrich
Copy link
Contributor

meets requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants