fix(vue): remove not used variable and replace by a proper one #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix is to PR #801, there was an error caused by wrong variable name ShowSpaceMenu instead of ShowDelWorkspaceModal This results in not opening modal window when clicking on "Delete Worskapce" menu item
acdmft
added
frontend
|
It's okay for me :) @acdmft Can you add this PR in the changelog file from the Unrelease section ? I think you can create a sub-section in the "Unrelease" that is "Fixed". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to PR #801, there was an error caused by wrong variable name ShowSpaceMenu instead of ShowDelWorkspaceModal. This resulted in an issue with space removal, when clicking on "Delete Worskapce" menu item the modal window didn't open.