Fix/modal window hide #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2023 15:17
when user gets an error during creation of a usergroup popover window continue to display This PR is intended to solve this issue using ref and function closeMenu with NcActions component.
…Action.opened = false with previous variant the focus rested on the 'x' icon and there've been a not nice outline around icon
acdmft
added
frontend
|
It's okay for me 😉 Congratulations @acdmft 🚀 |
zak39
approved these changes
May 16, 2023
acdmft
pushed a commit
that referenced
this pull request
May 29, 2023
this fix is to PR #801, there was an error caused by wrong variable name ShowSpaceMenu instead of ShowDelWorkspaceModal This results in not opening modal window when clicking on "Delete Worskapce" menu item
zak39
pushed a commit
that referenced
this pull request
May 31, 2023
this fix is to PR #801, there was an error caused by wrong variable name ShowSpaceMenu instead of ShowDelWorkspaceModal This results in not opening modal window when clicking on "Delete Worskapce" menu item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when user submits a not valid usergroup name the corresponding error appears, it is covered by popover menu of the NcActions component. This PR fixes this bug with the use of ref and opened props