Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLCronJob status update #1526

Merged
merged 11 commits into from
Dec 7, 2023
Merged

MLCronJob status update #1526

merged 11 commits into from
Dec 7, 2023

Conversation

jwierzbo
Copy link
Collaborator

@jwierzbo jwierzbo commented Dec 5, 2023

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2023
@jwierzbo jwierzbo marked this pull request as ready for review December 6, 2023 12:09
@jwierzbo jwierzbo requested a review from a team as a code owner December 6, 2023 12:09
chart/kube-arangodb/templates/ml-operator/role.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,18 @@
apiVersion: ml.arangodb.com/v1alpha1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove example, we will provide example in docs later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? it is useful for quick tests...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will generate it in examples and readme for all objects

pkg/apis/ml/v1alpha1/extension_conditions.go Outdated Show resolved Hide resolved
@jwierzbo jwierzbo merged commit 244c362 into master Dec 7, 2023
3 checks passed
@jwierzbo jwierzbo deleted the ml-cron-job_handler branch December 7, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants