MLCronJob status update

arangodb · Dec 6, 2023 · 51ab3ba · 51ab3ba
1 parent 749c04b
commit 51ab3ba
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/chart/kube-arangodb/templates/ml-operator/role.yaml b/chart/kube-arangodb/templates/ml-operator/role.yaml
@@ -52,5 +52,9 @@ rules:
         - "secrets"
         - "serviceaccounts"
       verbs: ["*"]
+    - apiGroups: ["batch"]
+      resources:
+        - "cronjobs"
+      verbs: ["*"]
 {{- end }}
 {{- end }}
diff --git a/pkg/apis/ml/v1alpha1/cronjob_spec.go b/pkg/apis/ml/v1alpha1/cronjob_spec.go
@@ -24,6 +24,7 @@ import (
 	batchApi "k8s.io/api/batch/v1"
 
 	"github.com/arangodb/kube-arangodb/pkg/apis/shared"
+	"github.com/arangodb/kube-arangodb/pkg/util/errors"
 )
 
 type ArangoMLCronJobSpec struct {
@@ -33,5 +34,14 @@ type ArangoMLCronJobSpec struct {
 }
 
 func (a *ArangoMLCronJobSpec) Validate() error {
-	return shared.WithErrors(shared.PrefixResourceErrors("spec"))
+	if a == nil {
+		return errors.Newf("Spec is not defined")
+	}
+
+	var err []error
+	if a.CronJobSpec == nil {
+		err = append(err, shared.PrefixResourceErrors("spec", errors.Newf("CronJobSpec is not defined")))
+	}
+
+	return shared.WithErrors(err...)
 }