Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(aws): Deprecate trivy aws as subcmd in favour of a plugin #6819

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 30, 2024

Description

Deprecates the aws from Trivy. Users can now install the aws plugin instead.

More details can be found in the deprecation notice here

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 marked this pull request as ready for review June 17, 2024 22:24
@simar7 simar7 requested a review from knqyf263 as a code owner June 17, 2024 22:24
@simar7
Copy link
Member Author

simar7 commented Jun 18, 2024

@knqyf263 once you're back, could you also take a look?

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some changes after aquasecurity/trivy-aws#181 and aquasecurity/trivy-plugin-index#12, but we can merge this PR and open another PR.

@simar7 simar7 force-pushed the deprecate-trivy-aws-as-subcmd branch from 54a067e to b69971d Compare June 20, 2024 16:55
@simar7 simar7 force-pushed the deprecate-trivy-aws-as-subcmd branch from 1e87835 to c826d70 Compare June 20, 2024 18:03
@simar7 simar7 added this pull request to the merge queue Jun 20, 2024
@simar7 simar7 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit b58d42d Jun 20, 2024
17 checks passed
@simar7 simar7 deleted the deprecate-trivy-aws-as-subcmd branch June 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants