-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): trivy-aws as a plugin for Trivy #153
Conversation
@simar7 Updated the docker version in the |
I think we want to add this plugin to the index so people can install this plugin by |
Yes I was going to do just that 👍🏼 @knqyf263 can you add the aquasecurity/trivy org as maintainers (or at least push access) to that repo? I could fork and submit a PR but it'd be nice to have the right access. |
@simar7 Added! |
Some packages such as ❯ ls pkg/cloud/aws
cache commands scanner
❯ ls pkg/
cache cloud commands concurrency errs progress scanner types |
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we build the plugin for the same platforms as Trivy to maintain backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add cross platform support later on if asked for. Feels like feature creep for this PR.
Notes
aws
subcommand will cause conflict if we name the plugin the same. So I've named itaws-scan
for now.aws
subcommand within trivy. This will still continue to work until we remove it however. Will done in a separate PR.Install
$ trivy plugin install ./trivy-aws.tar.gz 2024-05-18T00:06:06-06:00 INFO Installing the plugin... url="./trivy-aws.tar.gz" 2024-05-18T00:06:08-06:00 INFO Loading the plugin metadata...
Run