Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(makefile): add Makefile #256

Merged
merged 5 commits into from
Nov 6, 2019
Merged

chore(makefile): add Makefile #256

merged 5 commits into from
Nov 6, 2019

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Nov 6, 2019 •
edited
Loading

ToDo

  • add Makefile
  • remove tar.gz
  • fix CI setting
  • separate unit & integration tests

Issue

Close #255

@knqyf263 knqyf263 self-assigned this Nov 6, 2019
@knqyf263 knqyf263 requested a review from danielpacak November 6, 2019 12:15
danielpacak
danielpacak approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just for the record:

  • We can separate unit & integration tests in another PR
  • There are some linter warnings but it's not in scope to fix them
  • Add $GOBIN to $PATH in order to run linter - not everyone may have this configured

@knqyf263 knqyf263 merged commit 4f92d29 into master Nov 6, 2019
@knqyf263 knqyf263 deleted the add_makefile branch November 6, 2019 14:47
GuaoGuao pushed a commit to GuaoGuao/trivy that referenced this pull request Jun 24, 2020
@knqyf263
chore(makefile): add Makefile (aquasecurity#256)
03b7033 
* chore(makefile): add Makefile

* chore(ci): use make

* chore(makefile): add clean

* chore(makefile): fix test commands

* chore(ci): split tests into the unit test and the integration test
liamg pushed a commit that referenced this pull request Jun 7, 2022
@knqyf263
chore(makefile): add Makefile (#256)
0e6bf5b 
* chore(makefile): add Makefile

* chore(ci): use make

* chore(makefile): add clean

* chore(makefile): fix test commands

* chore(ci): split tests into the unit test and the integration test
liamg pushed a commit that referenced this pull request Jun 7, 2022
@mmorel-35 @knqyf263
ci(lint) : setup golangci-lint-action (#256)
d4a9fe5 
* build(lint): setup golangci-lint-action

Signed-off-by: Matthieu MOREL <[email protected]>

* skip go installation

Co-authored-by: knqyf263 <[email protected]>
liamg pushed a commit that referenced this pull request Jun 7, 2022
@mmorel-35 @knqyf263
ci(lint) : setup golangci-lint-action (#256)
01fd3bd 
* build(lint): setup golangci-lint-action

Signed-off-by: Matthieu MOREL <[email protected]>

* skip go installation

Co-authored-by: knqyf263 <[email protected]>
josedonizetti referenced this pull request in josedonizetti/trivy Jun 24, 2022
fix: involve the public access block in the check for public acl (#256)
d2da58b 
* fix: involve the public access block in the check for public acl
* fix: add nil check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpacak danielpacak danielpacak approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go library: downloaded zip file too large
2 participants
@knqyf263 @danielpacak