fix: involve the public access block in the check for public acl (#256)

* fix: involve the public access block in the check for public acl * fix: add nil check
josedonizetti · Feb 10, 2022 · d2da58b · d2da58b
1 parent f21999d
commit d2da58b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/provider/aws/s3/bucket.go b/provider/aws/s3/bucket.go
@@ -16,6 +16,10 @@ type Bucket struct {
 func (b *Bucket) HasPublicExposureACL() bool {
 	for _, publicACL := range []string{"public-read", "public-read-write", "website", "authenticated-read"} {
 		if b.ACL.EqualTo(publicACL) {
+			// if there is a public access block, check the public ACL blocks
+			if b.PublicAccessBlock != nil && b.PublicAccessBlock.IsManaged() {
+				return b.PublicAccessBlock.IgnorePublicACLs.IsFalse() && b.PublicAccessBlock.BlockPublicACLs.IsFalse()
+			}
 			return true
 		}
 	}