Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor parquet extractor backfill support function #613

Merged

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Nov 20, 2024

this will reduce some potential duplicate codes from parquet migration

Test Plan

Screenshot 2024-11-21 at 11 54 45 AM

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm marked this pull request as ready for review November 20, 2024 23:44
@yuunlimm yuunlimm requested a review from a team November 20, 2024 23:44
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.5%. Comparing base (e3795ed) to head (be7a2e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dk-processor/src/utils/parquet_extractor_helper.rs 0.0% 5 Missing ⚠️
...uet_default_processor/parquet_default_extractor.rs 0.0% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e3795ed) and HEAD (be7a2e0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e3795ed) HEAD (be7a2e0)
2 1
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #613      +/-   ##
========================================
- Coverage   48.6%   34.5%   -14.1%     
========================================
  Files        186     186              
  Lines      24911   24904       -7     
========================================
- Hits       12129    8616    -3513     
- Misses     12782   16288    +3506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yuunlimm yuunlimm merged commit 3d22e3b into main Nov 21, 2024
11 checks passed
@yuunlimm yuunlimm deleted the 11-20-refactor_parquet_extractor_backfill_support_function branch November 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants