Add order step to SDK processors
#544
Merged
+38
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rtso
force-pushed
the
10-07-fa_add_order_step
branch
from
88b390f to
3fe6b03
Compare
dermanyang
reviewed
Oct 8, 2024
|
|
||
| const UPDATE_PROCESSOR_STATUS_SECS: u64 = 1; | ||
| pub const UPDATE_PROCESSOR_STATUS_SECS: u64 = 1; |
There was a problem hiding this comment.
should this be a config thing?
There was a problem hiding this comment.
Yeah this can be the default, but it should be configurable per processor.
There was a problem hiding this comment.
@dermanyang could you include this change (accepting a polling_duration param) with the other changes you're making to LatestVersionTracker?
dermanyang
approved these changes
Oct 8, 2024
rtso
force-pushed
the
10-07-fa_add_order_step
branch
from
3fe6b03 to
40bc6e1
Compare
rtso
force-pushed
the
graphite-base/544
branch
from
c194dad to
e4ef014
Compare
rtso
force-pushed
the
10-07-fa_add_order_step
branch
from
40bc6e1 to
07482c2
Compare
rtso
force-pushed
the
10-07-fa_add_order_step
branch
from
07482c2 to
8defcfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds OrderByVersionStep to events and FA processors. It also updates LatestVersionTrackerStep to assume the transactions batches are coming in order.
Next PR: Parallelize storer
Testing
Run FA processor