Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FA processor to SDK #543

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Migrate FA processor to SDK #543

merged 4 commits into from
Oct 8, 2024

Conversation

rtso
Copy link
Collaborator

@rtso rtso commented Oct 7, 2024

Description

  • Upgrade SDK dependency to latest version
  • Migrate FungibleAssetProcessor to
    • Add FungibleAssetExtractor and FungibleAssetStorer steps
    • Update config to support FungibleAssetProcessor
    • Add support for deprecated tables flags

Testing

Run fa processor

Screenshot 2024-10-07 at 6.46.53 PM.png

@rtso rtso changed the title migrate fa processor to sdk Migrate fa processor to SDK Oct 7, 2024
Copy link
Collaborator Author

rtso commented Oct 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso changed the title Migrate fa processor to SDK Migrate FA processor to SDK Oct 7, 2024
@rtso rtso marked this pull request as ready for review October 7, 2024 22:47
@dermanyang
Copy link
Contributor

If we're thinking about adding documentation as we migrate these processors over to the SDK, it would be nice if we standardize where we write that documentation. maybe just in the struct definition in fungible_asset_processor.rs . Which steps are needed/what's unique to this processor oslt. What do we think?

@rtso
Copy link
Collaborator Author

rtso commented Oct 8, 2024

@dermanyang good call, I'll add some documentation in the next PR. I think the documentation should be inside each step. FungibleAssetExtractor includes most of the processing logic, and we should document each loop and what is being extracted.

@rtso rtso merged commit e4ef014 into main Oct 8, 2024
7 checks passed
Copy link
Collaborator Author

rtso commented Oct 8, 2024

Merge activity

  • Oct 8, 5:07 PM EDT: @rtso merged this pull request with Graphite.

@rtso rtso deleted the 10-07-migrate_fa branch October 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants