-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EI-397] Separate fungible asset and token indexing #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
force-pushed
the
rtso/fungible-token
branch
from
April 25, 2024 18:31
75fa401
to
a723c3e
Compare
rtso
changed the title
Re-index fungible token
Separate fungible asset and token indexing
Apr 25, 2024
ying-w
reviewed
Apr 25, 2024
ying-w
reviewed
Apr 25, 2024
rtso
changed the title
Separate fungible asset and token indexing
[EI-397] Separate fungible asset and token indexing
Apr 30, 2024
bowenyang007
reviewed
May 1, 2024
rust/processor/src/models/fungible_asset_models/v2_fungible_metadata.rs
Outdated
Show resolved
Hide resolved
bowenyang007
reviewed
May 1, 2024
bowenyang007
reviewed
May 1, 2024
bowenyang007
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea looks good. a few questions about setting the deprecated fields to null always but overall nice clean up!
rtso
force-pushed
the
rtso/fungible-token
branch
2 times, most recently
from
May 2, 2024 23:14
81bdb49
to
722fc42
Compare
yuunlimm
pushed a commit
that referenced
this pull request
May 9, 2024
* Re-index fungible token * Test move script * Schema changes * Comments * on conflict, update * Fix is_fungible_v2 column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Index fungible assets and tokens independently, to better reflect the composable nature of the object model on chain
maximum_v2
andsupply_v2
tofungible_asset_metadata
(copied fromcurrent_token_datas_v2
)maximum
,supply
,decimals
fromtoken_datas_v2
current_token_datas_v2.is_fungible_v2
fungible_asset_metadata.is_token_v2
token_activities_v2.is_fungible_v2
current_token_ownerships_v2.is_fungible_v2
token_ownerships_v2.is_fungible_v2
Proposal: https://www.notion.so/aptoslabs/Indexer-Remove-DB-Lookups-16b8fc8c19fb4c79900e7dc35b0da9ef?d=210b8f48ab3c45fcbc971440836096fd#8dd1c16eebd440a6809b795a8041b1a8
Test plan
Run move scripts to create token mint, transfer, burn txn's. Run token_v2_processor and fungile_asset_processor on the txn's.
Mint fungible token
https://explorer.aptoslabs.com/txn/1033408820/userTxnOverview?network=testnet
Token tables
Fungible asset tables
Joins
Transfer fungible token
https://explorer.aptoslabs.com/txn/1033409449?network=testnet
Token tables had no change.
Fungible asset tables
FA balance changed.
Joins
Burn fungible asset
https://explorer.aptoslabs.com/txn/1033409890?network=testnet
Token tables had no change.
Fungible asset tables
FA balance changed.
Joins