add tranche 2 parquet models #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-w
reviewed
Jun 28, 2024
rust/processor/src/db/common/models/coin_models/parquet_coin_supply.rs
Outdated
Show resolved
Hide resolved
rust/processor/src/db/common/models/default_models/parquet_move_modules.rs
Outdated
Show resolved
Hide resolved
| pub is_primary: bool, | ||
| pub is_frozen: bool, | ||
| pub amount: u64, | ||
| pub transaction_timestamp: chrono::NaiveDateTime, |
There was a problem hiding this comment.
transaction_timestamp -> block_timestamp
double check amount is u64 not u128
There was a problem hiding this comment.
@larry-aptos I think the question is more like this whether it's supposed to be u128 or u64
There was a problem hiding this comment.
@rtso the FA expert. what's the intended behavior for balances? like octa in integer right?
rust/processor/src/db/common/models/token_v2_models/parquet_v2_collections.rs
Outdated
Show resolved
Hide resolved
rust/processor/src/db/common/models/token_v2_models/parquet_v2_token_datas.rs
Outdated
Show resolved
Hide resolved
rust/processor/src/db/common/models/token_v2_models/parquet_v2_token_ownerships.rs
Outdated
Show resolved
Hide resolved
rust/processor/src/db/common/models/user_transactions_models/parquet_signatures.rs
Outdated
Show resolved
Hide resolved
yuunlimm
force-pushed
the
yuunlimm/parquet-tranche2-models
branch
from
668ab74 to
09baec7
Compare
yuunlimm
force-pushed
the
yuunlimm/parquet-tranche2-models
branch
from
09baec7 to
ca7ae80
Compare
ying-w
reviewed
Jul 3, 2024
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/default_models/parquet_move_modules.rs
Outdated
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/default_models/parquet_move_modules.rs
Outdated
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/default_models/parquet_move_modules.rs
Outdated
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/fungible_asset_models/mod.rs
Outdated
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/fungible_asset_models/parquet_coin_supply.rs
Outdated
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/token_v2_models/parquet_v2_token_datas.rs
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/token_v2_models/parquet_v2_token_ownerships.rs
Outdated
Show resolved
Hide resolved
yuunlimm
commented
Jul 3, 2024
rust/processor/src/db/common/models/token_v2_models/parquet_v2_token_ownerships.rs
Show resolved
Hide resolved
yuunlimm
force-pushed
the
yuunlimm/parquet-tranche2-models
branch
2 times, most recently
from
a8e218c to
dc1e398
Compare
yuunlimm
force-pushed
the
yuunlimm/parquet-tranche2-models
branch
from
dc1e398 to
4248fbd
Compare
yuunlimm
commented
Jul 3, 2024
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/default_models/parquet_transactions.rs
Show resolved
Hide resolved
ying-w
reviewed
Jul 3, 2024
| @@ -103,6 +107,7 @@ impl Transaction { | |||
| block_height: i64, | |||
| epoch: i64, | |||
| block_timestamp: chrono::NaiveDateTime, | |||
| txn_size_info: Option<&TransactionSizeInfo>, | |||
ying-w
reviewed
Jul 3, 2024
rust/processor/src/db/common/models/events_models/parquet_events.rs
Outdated
Show resolved
Hide resolved
larry-aptos
reviewed
Jul 12, 2024
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive( | ||
| Allocative, Clone, Debug, Default, Deserialize, FieldCount, ParquetRecordWriter, Serialize, |
There was a problem hiding this comment.
is Deserialize and Serialize required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding parquet models for tranche 2 for the following tables:
ans_primary_name_v2
Test plan
This is just to get aligned on the model schemas, nothing to test yet.