-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VersionTrackerStep to Common Steps in the SDK #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
reviewed
Oct 8, 2024
aptos-indexer-processors-sdk/sdk/src/common_steps/version_tracker_step.rs
Outdated
Show resolved
Hide resolved
aptos-indexer-processors-sdk/sdk/src/common_steps/version_tracker_step.rs
Show resolved
Hide resolved
dermanyang
changed the title
[WIP] Add version tracker to sdk
Add VersionTrackerStep to Common Steps in the SDK
Oct 8, 2024
rtso
approved these changes
Oct 9, 2024
aptos-indexer-processors-sdk/sdk/src/common_steps/version_tracker_step.rs
Show resolved
Hide resolved
aptos-indexer-processors-sdk/sdk/src/common_steps/version_tracker_step.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce the
LatestVersionProcessedTracker
as a common step in the SDK so processors across inaptos-indexer-processors
andaptos-indexer-processor-example
can reuse the same code.Example usage in PR#8 of the example repo:
Technical Overview
To prevent a
migrations/
directory in the SDK which would cause many forks an adapter trait object,ProcessorStatusSaver
with methodsave_processor_status
, is used.Testing
Tested manually in examples repo by refactoring the events processor to use this step: aptos-labs/aptos-indexer-processor-example#8