Refactor Example Events Processor to use VersionTracker common step from SDK #8
Conversation
dermanyang
changed the title
| @@ -10,4 +10,4 @@ server_config: | |||
| auth_token: "AUTH_TOKEN" | |||
| request_name_header: "events-processor" | |||
| db_config: | |||
| postgres_connection_string: postgresql://postgres:@localhost:5432/example | |||
| postgres_connection_string: postgresql://seanyang:@localhost:5432/example | |||
| }; | ||
| use async_trait::async_trait; | ||
| use diesel::{upsert::excluded, ExpressionMethods}; | ||
| pub struct ProcessorStatusSaverImpl { |
There was a problem hiding this comment.
should we name this DefaultProcessorStatusSaver? also usually we leave out Impl from the struct names.
There was a problem hiding this comment.
Renamed as suggested. I also moved it to a new dir called common, what do you think? Since its not specific to the events processor. I didn't name the dir common_steps as its not actually a step... Alternately, I can create a factory-like method that returns a VersionTrackerStep with the appropriate ProcessorStatusSaver so that we can keep the dir name common_steps as the processor repo.
There was a problem hiding this comment.
I'm going with the latter suggestion as it prevents some duplicate code in the processor, too. That change will be in https://github.com/aptos-labs/aptos-indexer-processor-example/pull/6/files which has been rebased on top of this PR.
There was a problem hiding this comment.
nit: rename file name to match with the struct name
There was a problem hiding this comment.
renamed to processor_status_saver which will ultimately also have the BackfillProcessorStatusSaver struct
| )), | ||
| Some(" WHERE processor_status.last_success_version <= EXCLUDED.last_success_version "), | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
do we need to map this to a ProcessorError?
There was a problem hiding this comment.
execute_with_better_error already returns a Result<usize, ProcessorError> type. Is that sufficient?
Purpose
Refactor the events processor to use the
VersionTrackercommon step from SDK instead of implementing the entireLatestVersionProcessedTracker(deleted) here. Implement the trait objectProcessorStatusSaverto pass into the VersionTracker step.Technical Overview
Implement the new
ProcessorStatusSaverfrom the SDK PR#63 to initialize the version tracker step.Testing
Ran locally:
