randomness #10: randomness API update from randomnet #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjma
requested review from
junkil-park,
davidiw,
movekevin and
wrwg
as code owners
alinush
approved these changes
Mar 1, 2024
zjma
requested review from
alinush and
zekun000
and removed request for
davidiw,
junkil-park,
wrwg and
movekevin
zjma
added
CICD:run-e2e-tests
danielxiangzl
approved these changes
Mar 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12335 +/- ##
=======================================
Coverage 64.0% 64.0%
=======================================
Files 796 796
Lines 176719 176708 -11
=======================================
+ Hits 113262 113265 +3
+ Misses 63457 63443 -14 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alinush
approved these changes
Mar 2, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
zjma
force-pushed
the
zjma/randomness_event_from_randomnet
branch
from
dfae88f to
e86181e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
zjma
added a commit
that referenced
this pull request
Mar 2, 2024
* [move] fixes to `randomness.move` (#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * fix specs --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
✅ Forge suite
|
zjma
added a commit
that referenced
this pull request
Mar 2, 2024
* [move] fixes to `randomness.move` (#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * fix specs --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
zjma
added a commit
that referenced
this pull request
Mar 3, 2024
* randomness type update 3 (#12202) * randomness #4: RandManager update from randomnet (#12224) * RandManager update from randomnet * lint * lint * randomness #5: consensus update from randomnet (#12225) * consensus update from randomnet * update * randomness #6: dkg manager update from randomnet (#12226) * consensus update from randomnet * update * update execution client api * dkg manager update from randomnet * avoid panic * make api, indexer, fake aptos db aware of block metadata ext txns (#12227) * randomness #8: framework update from randomnet (#12228) * framework update from randomnet Squashed commit of the following to fix jwk smoke tests: commit 3bd0154 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:47:57 2024 -0800 update commit 2eb6add Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:12:27 2024 -0800 update commit 9d82151 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 01:51:08 2024 -0800 debug fix doc test fix spec fix doc update initialization in genesis update features.move initialize randomness in genesis update golden files private entry fun check and vm updates * postpone release builder changes * update goldenfiles * fix is_safe_call spec * randomness #9: smoke tests from randomnet (#12282) * smoke test deps and 1st case from randomnet * update * more smoke tests * randomness #10: randomness API update from randomnet (#12335) * [move] fixes to `randomness.move` (#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * fix specs --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * lint * update genesis * on-chain resources to indicate dkg/randomness failure injection (#12345) * dkg/randomness failure injection * update * smoke test * update * update * fix scripts --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[move] fixes to randomness.move
Fixed the Prover spec
Fixed the spec to unblock the PR.
Need to prove the introduced assumptions with proper loop invariants, which should be provable.
Description
Test Plan