Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomness #9: smoke tests from randomnet #12282

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 28, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 28, 2024

⏱️ 41h 4m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 8h 39m 🟥🟥🟩 (+6 more)
rust-smoke-tests 4h 46m 🟥🟩🟩🟩 (+5 more)
rust-unit-coverage 4h 29m 🟩
windows-build 3h 53m 🟩🟩🟩🟩🟩 (+6 more)
rust-smoke-coverage 3h 24m 🟩
execution-performance / single-node-performance 3h 16m 🟩🟩🟩🟩🟩 (+5 more)
rust-images / rust-all 2h 31m 🟩🟩🟩🟩🟩 (+5 more)
forge-e2e-test / forge 1h 58m 🟩🟩🟩🟩 (+5 more)
forge-compat-test / forge 1h 50m 🟩🟩🟩🟩 (+5 more)
rust-lints 1h 25m 🟩🟩🟩🟩🟩 (+6 more)
run-tests-main-branch 59m 🟥🟥🟩🟩🟩 (+6 more)
cli-e2e-tests / run-cli-tests 55m 🟩🟩🟩🟩 (+5 more)
check 44m 🟩🟩🟩🟩🟩 (+6 more)
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 24m 🟩🟩🟩🟩 (+5 more)
general-lints 24m 🟩🟩🟩🟩🟩 (+6 more)
check-dynamic-deps 22m 🟩🟩🟩🟩🟩 (+6 more)
rust-move-tests 20m 🟩
rust-move-unit-coverage 18m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 9m 🟩🟩🟩🟩🟩 (+5 more)
semgrep/ci 5m 🟩🟩🟩🟩🟩 (+6 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+6 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+6 more)
execution-performance / file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
permission-check 55s 🟩🟩🟩🟩🟩 (+6 more)
permission-check 50s 🟩🟩🟩🟩🟩 (+6 more)
permission-check 46s 🟩🟩🟩🟩🟩 (+6 more)
permission-check 41s 🟩🟩🟩🟩🟩 (+6 more)
permission-check 30s 🟩🟩🟩🟩🟩 (+5 more)
determine-docker-build-metadata 22s 🟩🟩🟩🟩🟩 (+5 more)
upload-to-codecov 14s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma marked this pull request as ready for review February 28, 2024 08:10
@zjma zjma requested review from zekun000 and danielxiangzl and removed request for davidiw, gregnazario, banool, wrwg and movekevin February 28, 2024 08:11
@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 28, 2024
@zjma zjma changed the title smoke test deps and 1st case from randomnet randomness #9: smoke test deps and 1st case from randomnet Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 37.48954% with 747 lines in your changes are missing coverage. Please review.

Project coverage is 70.2%. Comparing base (eab81de) to head (b6a9560).

❗ Current head b6a9560 differs from pull request most recent head 4c18715. Consider uploading reports for the commit 4c18715 to get more accurate results

Files Patch % Lines
consensus/src/rand/rand_gen/types.rs 15.2% 144 Missing ⚠️
consensus/src/pipeline/execution_client.rs 0.0% 130 Missing ⚠️
consensus/src/epoch_manager.rs 23.2% 119 Missing ⚠️
dkg/src/dkg_manager/mod.rs 43.9% 102 Missing ⚠️
consensus/src/rand/rand_gen/rand_manager.rs 0.0% 64 Missing ⚠️
aptos-move/framework/src/natives/randomness.rs 27.7% 26 Missing ⚠️
consensus/src/rand/rand_gen/storage/db.rs 0.0% 21 Missing ⚠️
dkg/src/transcript_aggregation/mod.rs 70.9% 16 Missing ⚠️
consensus/src/counters.rs 0.0% 14 Missing ⚠️
dkg/src/agg_trx_producer.rs 12.5% 14 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12282       +/-   ##
===========================================
+ Coverage    64.0%    70.2%     +6.1%     
===========================================
  Files         796     2242     +1446     
  Lines      176719   423096   +246377     
===========================================
+ Hits       113262   297225   +183963     
- Misses      63457   125871    +62414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zjma zjma force-pushed the zjma/smoke-test-deps-n-1st-case-from-randomnet branch from b6a9560 to 5b38174 Compare February 28, 2024 10:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zjma zjma force-pushed the zjma/framework_update_from_randomnet branch from a5c3a11 to 7fe30ff Compare February 28, 2024 14:52

This comment has been minimized.

This comment has been minimized.

@zjma zjma force-pushed the zjma/smoke-test-deps-n-1st-case-from-randomnet branch from b44960f to 8e42a87 Compare February 29, 2024 13:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zjma zjma force-pushed the zjma/framework_update_from_randomnet branch from d85a6bd to fbb61a2 Compare March 1, 2024 12:44
@zjma zjma force-pushed the zjma/smoke-test-deps-n-1st-case-from-randomnet branch from 8e42a87 to 2670159 Compare March 1, 2024 13:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Base automatically changed from zjma/framework_update_from_randomnet to main March 1, 2024 21:33
@zjma zjma force-pushed the zjma/smoke-test-deps-n-1st-case-from-randomnet branch from 2670159 to 4c18715 Compare March 1, 2024 22:06
@zjma zjma enabled auto-merge (squash) March 1, 2024 22:24

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

✅ Forge suite realistic_env_max_load success on 4c187150d724cb1ea080da2411eafcb2223f1721

two traffics test: inner traffic : committed: 7670 txn/s, latency: 5114 ms, (p50: 4800 ms, p90: 6000 ms, p99: 10500 ms), latency samples: 3313720
two traffics test : committed: 100 txn/s, latency: 1882 ms, (p50: 1800 ms, p90: 2000 ms, p99: 4600 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.241, avg: 0.205", "QsPosToProposal: max: 0.318, avg: 0.261", "ConsensusProposalToOrdered: max: 0.453, avg: 0.426", "ConsensusOrderedToCommit: max: 0.374, avg: 0.311", "ConsensusProposalToCommit: max: 0.818, avg: 0.737"]
Max round gap was 1 [limit 4] at version 1618633. Max no progress secs was 3.975971 [limit 15] at version 1618633.
Test Ok

Copy link
Contributor

github-actions bot commented Mar 1, 2024

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 4c187150d724cb1ea080da2411eafcb2223f1721

Compatibility test results for aptos-node-v1.9.5 ==> 4c187150d724cb1ea080da2411eafcb2223f1721 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6727 txn/s, latency: 5006 ms, (p50: 4800 ms, p90: 9300 ms, p99: 9900 ms), latency samples: 235460
2. Upgrading first Validator to new version: 4c187150d724cb1ea080da2411eafcb2223f1721
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 705 txn/s, latency: 35551 ms, (p50: 39800 ms, p90: 54700 ms, p99: 56400 ms), latency samples: 57880
3. Upgrading rest of first batch to new version: 4c187150d724cb1ea080da2411eafcb2223f1721
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 249 txn/s, submitted: 540 txn/s, expired: 291 txn/s, latency: 35776 ms, (p50: 32600 ms, p90: 51700 ms, p99: 61100 ms), latency samples: 22191
4. upgrading second batch to new version: 4c187150d724cb1ea080da2411eafcb2223f1721
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2222 txn/s, latency: 12755 ms, (p50: 13300 ms, p90: 19000 ms, p99: 19900 ms), latency samples: 111100
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 4c187150d724cb1ea080da2411eafcb2223f1721 passed
Test Ok

@zjma zjma merged commit 4a507f1 into main Mar 1, 2024
75 of 81 checks passed
@zjma zjma deleted the zjma/smoke-test-deps-n-1st-case-from-randomnet branch March 1, 2024 23:04
zjma added a commit that referenced this pull request Mar 2, 2024
* smoke test deps and 1st case from randomnet

* update

* more smoke tests
zjma added a commit that referenced this pull request Mar 2, 2024
* smoke test deps and 1st case from randomnet

* update

* more smoke tests
zjma added a commit that referenced this pull request Mar 3, 2024
* randomness type update 3 (#12202)

* randomness #4: RandManager update from randomnet (#12224)

* RandManager update from randomnet

* lint

* lint

* randomness #5: consensus update from randomnet (#12225)

* consensus update from randomnet

* update

* randomness #6: dkg manager update from randomnet (#12226)

* consensus update from randomnet

* update

* update execution client api

* dkg manager update from randomnet

* avoid panic

* make api, indexer, fake aptos db aware of block metadata ext txns (#12227)

* randomness #8: framework update from randomnet (#12228)

* framework update from randomnet

Squashed commit of the following to fix jwk smoke tests:

commit 3bd0154
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:47:57 2024 -0800

    update

commit 2eb6add
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:12:27 2024 -0800

    update

commit 9d82151
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 01:51:08 2024 -0800

    debug

fix doc test

fix spec

fix doc

update initialization in genesis

update features.move

initialize randomness in genesis

update golden files

private entry fun check and vm updates

* postpone release builder changes

* update goldenfiles

* fix is_safe_call spec

* randomness #9: smoke tests from randomnet (#12282)

* smoke test deps and 1st case from randomnet

* update

* more smoke tests

* randomness #10: randomness API update from randomnet (#12335)

* [move] fixes to `randomness.move` (#12250)

* [move] fixes to randomness.move

* Fixed the Prover spec

Fixed the spec to unblock the PR.

Need to prove the introduced assumptions with proper loop invariants, which should be provable.

* lint

---------

Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* fix specs

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* lint

* update genesis

* on-chain resources to indicate dkg/randomness failure injection (#12345)

* dkg/randomness failure injection

* update

* smoke test

* update

* update

* fix scripts

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants