This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Upgrade ember-cli & Clipboard handling. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tees up a fix for issue #387. Removes Zeroclipboard in favor of Clipboard: - no flash dependency - offers a nice “Press ⌘+C to copy” message (configurable) for safari and browsers that don’t support JS setting the clipboard Updates the `click-to-copy` component: - can set all the success / error messages in the tooltips - can set the trigger text the user clicks to copy - isolated css - no more anchor tag with `#` href that would reload the page in browsers without Flash Tests will fail due to various ember package updates. Thanks to @rwjblue for the help and offering to look at these failures. Thanks @sandersonet for the testing help!
rwjblue
added a commit
that referenced
this pull request
Oct 26, 2015
Upgrade ember-cli & Clipboard handling.
|
Thank you @rwjblue!! |
skylar-anderson
pushed a commit
to skylar-anderson/dashboard.aptible.com
that referenced
this pull request
Apr 21, 2016
Closes aptible#387 with a new plug in that does not use flash, [Clipboard.js](http://zenorocha.github.io/clipboard.js/). Thanks @rwjblue for the help on the shared updates: aptible/ember-cli-aptible-shared#64 Got some help from @sandersonet on this too. Thanks and go team!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
.jshintrcto properly warn on unused variablesMockAnalyticsproperly.this.setis not called when destroyingclick-to-copy