Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Hide the copy-to-clipboard action if browser does not have Flash #387

Closed
gib opened this issue Jul 28, 2015 · 2 comments · Fixed by #481
Closed

Hide the copy-to-clipboard action if browser does not have Flash #387

gib opened this issue Jul 28, 2015 · 2 comments · Fixed by #481
Assignees

Comments

@gib
Copy link
Contributor

gib commented Jul 28, 2015

Hide the "Copy" link on database connection URLs if the browser does not have Flash.

@gib
Copy link
Contributor Author

gib commented Sep 29, 2015

Might be useful... http://zenorocha.github.io/clipboard.js/

@zenorocha
Copy link

+1 ;)

@gib gib closed this as completed in #479 Oct 26, 2015
@gib gib mentioned this issue Oct 27, 2015
skylar-anderson pushed a commit to skylar-anderson/dashboard.aptible.com that referenced this issue Apr 21, 2016
Updates `ember-cli-aptible-shared` to leverage the new `click-to-copy`
component to fix issue aptible#387.

Also removes up an unused CSS file.

See aptible/ember-cli-aptible-shared#58
skylar-anderson pushed a commit to skylar-anderson/dashboard.aptible.com that referenced this issue Apr 21, 2016
Closes aptible#387 with
a new plug in that does not use flash,
[Clipboard.js](http://zenorocha.github.io/clipboard.js/).

Thanks @rwjblue for the help on the shared updates:
aptible/ember-cli-aptible-shared#64

Got some help from @sandersonet on this too. Thanks and go team!
skylar-anderson pushed a commit to skylar-anderson/dashboard.aptible.com that referenced this issue Aug 22, 2016
This tees up a fix for issue aptible#387.

Removes Zeroclipboard in favor of Clipboard:
- no flash dependency
- offers a nice “Press ⌘+C to copy” message (configurable) for safari
and browsers that don’t support JS setting the clipboard

Updates the `click-to-copy` component:
- can set all the success / error messages in the tooltips
- can set the trigger text the user clicks to copy
- isolated css
- no more anchor tag with `#` href that would reload the page in
browsers without Flash

Tests will fail due to various ember package updates. Thanks to
@rwjblue for the help and offering to look at these failures.

Thanks @sandersonet for the testing help!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants