Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turned on learnability flags on by default #33283

Merged
merged 11 commits into from
May 13, 2024
Merged

fix: turned on learnability flags on by default #33283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29f9fa7
fix: turned on learnability flags on by default
May 8, 2024
06cc1c5
fix: failing cypress tests issue fixed
May 8, 2024
36114b6
fix: flags on by default
May 8, 2024
95d0916
fix: failing cypress test cases fixed
May 9, 2024
3824fc2
Merge branch 'release' into fix/learnability-flags-on
May 9, 2024
b95ebe1
fix: propertyControl updates
May 10, 2024
aabb675
Merge branch 'release' into fix/learnability-flags-on
May 10, 2024
c23ac48
Merge branch 'release' into fix/learnability-flags-on
May 10, 2024
c85c508
Merge branch 'release' into fix/learnability-flags-on
May 13, 2024
f82251c
Merge branch 'release' into fix/learnability-flags-on
May 13, 2024
e430215
fix: reverted tag all
May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ describe(

agHelper.GetNClick(oneClickBindingLocator.datasourceQuerySelector(), 0);

agHelper.AssertElementExist(
oneClickBindingLocator.dropdownOptionSelector("Query1"),
);

propPane.ToggleJSMode("Table data");

propPane.ValidatePropertyFieldValue("Table data", "{{Query1.data}}");

propPane.AssertJSToggleState("Table data", "enabled");
Expand Down
2 changes: 2 additions & 0 deletions app/client/cypress/support/Objects/FeatureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import produce from "immer";

const defaultFlags = {
release_side_by_side_ide_enabled: true,
ab_learnability_discoverability_collapse_all_except_data_enabled: false, // remove this flag from here when it's removed from code
AmanAgarwal041 marked this conversation as resolved.
Show resolved Hide resolved
rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code
};

export const featureFlagIntercept = (
Expand Down
8 changes: 4 additions & 4 deletions app/client/src/ce/entities/FeatureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
release_global_add_pane_enabled: false,
ab_appsmith_ai_query: false,
release_actions_redesign_enabled: false,
rollout_remove_feature_walkthrough_enabled: false,
rollout_js_enabled_one_click_binding_enabled: false,
rollout_remove_feature_walkthrough_enabled: true,
rollout_js_enabled_one_click_binding_enabled: true,
rollout_side_by_side_enabled: false,
ab_learnability_ease_of_initial_use_enabled: false,
ab_learnability_discoverability_collapse_all_except_data_enabled: false,
ab_learnability_ease_of_initial_use_enabled: true,
ab_learnability_discoverability_collapse_all_except_data_enabled: true,
release_layout_conversion_enabled: false,
};

Expand Down
Loading