fix: turned on learnability flags on by default

[sneha122]

Description

For the airgapped testing, we need to remove all the feature flags which are already rolled out to 100% of the users. As part of this task, we have 3 flags in activation/learnability initiatives:

1. rollout_js_enabled_one_click_binding_enabled
2. ab_learnability_ease_of_initial_use_enabled
3. ab_learnability_discoverability_collapse_all_except_data_enabled
4. rollout_remove_feature_walkthrough_enabled

As immediate measure, we are turning default values of these flags to be true, later on we can plan to completely remove the flags from the code.

Fixes #33224
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9059739090
Commit: e430215
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js

To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

The recent changes focus on enhancing feature flags and test configurations. Two feature flags related to learnability have been activated, and new flags have been added to the testing framework. Additionally, the test suite has been adjusted by modifying the focus of certain tests and updating the list of limited tests to include a new spec file.

Changes

File Path	Change Summary
app/client/src/ce/entities/FeatureFlag.ts app/client/cypress/support/Objects/FeatureFlags.ts	Updated feature flag values related to learnability. Added new flags for testing.
app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts	Refocused test objectives, removing some assertions and adding others.
app/client/cypress/limited-tests.txt	Updated the list of limited tests to include PropertyControl_spec.ts.

Assessment against linked issues

Objective	Addressed	Explanation
Activation flags rolled out to 100% should be true by default (#33224)	✅	The feature flags ab_learnability_ease_of_initial_use_enabled and ab_learnability_discoverability_collapse_all_except_data_enabled have been set to true, aligning with the task requirement.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sneha122]

/ci-test-limit

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9030457574.
Cypress dashboard
PR: #33283.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (7)

app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts (7)

Line range hint 1-1: Ensure imports are used efficiently and remove any unused imports to keep the code clean.

---

Line range hint 18-18: Consider adding a brief comment explaining the purpose of the before block for better readability and maintainability.

---

Line range hint 20-20: Ensure that the test description accurately reflects the actions and assertions performed in the test.

---

Line range hint 21-21: Consider using constants for repeated literal values like timeouts to enhance maintainability.

- cy.wait(500);
+ const SHORT_WAIT_TIME = 500;
+ cy.wait(SHORT_WAIT_TIME);

---

Line range hint 24-24: Consider refactoring repeated actions into helper functions to improve code readability and reusability.

- dataSources.NavigateToDSCreateNew();
- dataSources.CreatePlugIn("Mongo");
- agHelper.RenameWithInPane(`dummy${I}`, false);
- agHelper.ClearNType(dataSources._host(), "127.0.0.1");
- agHelper.ClearNType(dataSources._port, "8000");
- dataSources.SaveDatasource();
+ createAndSaveDataSource(`dummy${I}`, "Mongo", "127.0.0.1", "8000");

---

Line range hint 26-26: Consider adding assertions to verify the state of the UI after each significant interaction.

+ agHelper.AssertElementExist(oneClickBindingLocator.datasourceDropdownSelector);

---

Line range hint 27-27: Add comments explaining the purpose of each block in this test case to enhance readability and maintainability.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9030457574.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉