-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix for the junit run-result cache saving issue #29529
Conversation
…h into ci/allow-junit-rerun
…h into ci/allow-junit-rerun
…h into ci/allow-junit-rerun
WalkthroughWalkthroughThe recent update involves a modification to a GitHub Actions workflow configuration. A new conditional check has been introduced to the server build process, specifically affecting the step that restores results from a previous run. This step is now designed to be skipped if the workflow is triggered with the 'skip-tests' input set to 'true'. There are no changes to the declarations of exported or public entities in the codebase. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
Description
Currently, when we run the server build without tests, we still try to check the cache for run-result, but as the cache is not present during the first run, where we just build the server, and on the success of the workflow, actions/cache create the cache with the specified key,
Which is creating an issue while we try to save the actual run-result cache when we run the tests in server-unit-tests.
Solution :
Type of change
Testing
Summary by CodeRabbit
Refactor
Chores