Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix for the junit run-result cache saving issue #29529

Merged
merged 74 commits into from
Dec 12, 2023

Conversation

sarojsarab
Copy link
Contributor

@sarojsarab sarojsarab commented Dec 12, 2023

Description

Currently, when we run the server build without tests, we still try to check the cache for run-result, but as the cache is not present during the first run, where we just build the server, and on the success of the workflow, actions/cache create the cache with the specified key,

Which is creating an issue while we try to save the actual run-result cache when we run the tests in server-unit-tests.

Solution :

  • Added a condition to check the cache present only while running tests

Type of change

  • Workflow changes (server-build.yml)

Testing

  • Workflow run

Summary by CodeRabbit

  • Refactor

    • Updated the server build process to conditionally skip certain steps based on user input.
  • Chores

    • Improved automation in the build workflow to enhance efficiency.

Saroj added 30 commits July 31, 2023 10:33
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels Dec 12, 2023
@sarojsarab
Copy link
Contributor Author

Workflow run

@sarojsarab sarojsarab marked this pull request as ready for review December 12, 2023 07:22
Copy link
Contributor

coderabbitai bot commented Dec 12, 2023

Walkthrough

Walkthrough

The recent update involves a modification to a GitHub Actions workflow configuration. A new conditional check has been introduced to the server build process, specifically affecting the step that restores results from a previous run. This step is now designed to be skipped if the workflow is triggered with the 'skip-tests' input set to 'true'. There are no changes to the declarations of exported or public entities in the codebase.

Changes

File Change Summary
.github/workflows/.../server-build.yml Added conditional check to skip "Restore the previous run result" step when 'skip-tests' input is 'true'.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Aishwarya-U-R Aishwarya-U-R merged commit 2550856 into release Dec 12, 2023
14 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the ci/Fixing-server-junit-cache branch December 12, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants