Skip to content

Commit

Permalink
ci: Fix for the junit run-result cache saving issue (#29529)
Browse files Browse the repository at this point in the history
## Description
Currently, when we run the server build without tests, we still try to
check the cache for run-result, but as the cache is not present during
the first run, where we just build the server, and on the success of the
workflow, actions/cache create the cache with the specified key,

Which is creating an issue while we try to save the actual run-result
cache when we run the tests in server-unit-tests.

Solution : 
- Added a condition to check the cache present only while running tests

#### Type of change
- Workflow changes (server-build.yml)
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the server build process to conditionally skip certain steps
based on user input.

- **Chores**
  - Improved automation in the build workflow to enhance efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sarojsarab authored Dec 12, 2023
1 parent 6e8bfc6 commit 2550856
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/server-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ jobs:

# In case this is second attempt try restoring status of the prior attempt from cache
- name: Restore the previous run result
if: inputs.skip-tests != 'true'
id: cache-appsmith
uses: actions/cache@v3
with:
Expand Down

0 comments on commit 2550856

Please sign in to comment.