[SE-0251] Additions to SIMD types. #23421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentyrone
force-pushed
the
simd-additions
branch
from
b76a194 to
fcbd3eb
Compare
- extension from 2 and 3-element vectors to 3- and 4-element vectors. - the .one member - swizzles via subscript-by-simd - min/max/sum reductions - min/max/clamp on vectors-of-comparable - any and all - copysign All of is is pending evolution review.
stephentyrone
force-pushed
the
simd-additions
branch
from
fcbd3eb to
4956b3e
Compare
Make permute subscript wrap on vector length, even for SIMD3 dictionaries. Also restore min/max to globals, rather than static functions.
stephentyrone
force-pushed
the
simd-additions
branch
from
4956b3e to
c4a0cf4
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility. |
stephentyrone
changed the title
|
Is this gtm? |
|
Yes. I wanted to check with you before pushing it in, but I’ll do it now and make a clone for 5.1 later today.
…Sent from my iPhone
On Apr 9, 2019, at 18:25, Ben Cohen ***@***.***> wrote:
Is this gtm?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
stephentyrone
added a commit
to stephentyrone/swift
that referenced
this pull request
Apr 11, 2019
* Additions to SIMD types. - extension from 2 and 3-element vectors to 3- and 4-element vectors. - the .one member - swizzles via subscript-by-simd - min/max/sum reductions - min/max/clamp on vectors-of-comparable - any and all - Make permute subscript wrap on vector length, even for SIMD3 dictionaries. Also restore min/max to globals, rather than static functions.
stephentyrone
added a commit
that referenced
this pull request
Apr 16, 2019
* Some cleanup of SIMDVector and SIMDVectorTypes source files. (#23389) Bring formatting closer in line with the rest of the standard lib, remove "public" from extensions (moving it onto the contents defined therein). Restore Swift project headers that were apparently lost at some point. * [SE-0251] Additions to SIMD types. (#23421) * Additions to SIMD types. - extension from 2 and 3-element vectors to 3- and 4-element vectors. - the .one member - swizzles via subscript-by-simd - min/max/sum reductions - min/max/clamp on vectors-of-comparable - any and all - Make permute subscript wrap on vector length, even for SIMD3 dictionaries. Also restore min/max to globals, rather than static functions. * Temporarily remove the global min(a,b) and max(a,b) SIMD functions. (#23960) These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/48276450