-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out system app when there are multiple active apps #204
Filter out system app when there are multiple active apps #204
Conversation
1deb90e
to
2a9ea96
Compare
4e6dd31
to
b9caf24
Compare
b9caf24
to
ed5a843
Compare
the test [[[FBRunLoopSpinner new]
timeout:5]
spinUntilTrue:^BOOL{
return [FBXCAXClientProxy.sharedClient activeApplications].count == 1;
}]; Locally, just to test, if I replace that I've reverted the spin check (from what I've committed initially) (which is actually what it should be) return [FBXCAXClientProxy.sharedClient activeApplications].count > 0; to what it was return [FBXCAXClientProxy.sharedClient activeApplications].count == 1; (and now it actually sleeps 5 seconds, because the and later might see how to make test |
Perhaps, it makes sense to change the test itself depending on the iOS version? |
ideally, test should not depend on iOS version. anyway, it's a separate issue. |
I don't like this fact very much. Is there any way to reduce the delay? |
Let's merge this PR for now. I'll create a separate issue for 5 seconds delay. |
@mykola-mokhnach Yes, i also didn't like the fact that it sleeps for 5 seconds. that's why I've changed the comparison from I think it's good to determine requirements here and edge cases.
|
Issue:
on iOS 13
[FBXCAXClientProxy.sharedClient activeApplications]
returns multiple entries (in my case - two).And there are situations when the
firstObject
isSpringBoard
- i.e. system application.This prevents proper list of elements.
Fix:
Filter out system applications from list of
activeApplications
in case there are more than one item.