Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Ditch FBApplication in favour of XCUIApplication extensions #834

Merged
merged 3 commits into from
Jan 13, 2024
Merged

refactor: Ditch FBApplication in favour of XCUIApplication extensions #834

merged 3 commits into from
Jan 13, 2024

Conversation

mykola-mokhnach
Copy link

This class was only creating extra confusion. I've also reworked the active session application detection logic a bit, so it should be more reliable and faster than before.

KazuCocoa
KazuCocoa reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested briefly on tvOS. I'll do on iOS later

WebDriverAgentLib/Utilities/FBXCodeCompatibility.m Outdated Show resolved Hide resolved
KazuCocoa
KazuCocoa approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on tvOS and iOS device by switching the foreground app and checking active app info. (and find element/interaction)

@mykola-mokhnach mykola-mokhnach merged commit 70a8d98 into master Jan 13, 2024
46 checks passed
@mykola-mokhnach mykola-mokhnach deleted the active_app branch January 13, 2024 19:49
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
@semantic-release-bot
chore(release): 5.15.7 [skip ci]
e011c7e 
## [5.15.7](v5.15.6...v5.15.7) (2024-01-16)

### Miscellaneous Chores

* **deps-dev:** bump semantic-release from 22.0.12 to 23.0.0 ([#836](#836)) ([a3ac2c5](a3ac2c5))

### Code Refactoring

* Ditch FBApplication in favour of XCUIApplication extensions ([#834](#834)) ([70a8d98](70a8d98))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.15.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

KazuCocoa added a commit that referenced this pull request Jan 31, 2024
@KazuCocoa
Revert "refactor: Ditch FBApplication in favour of XCUIApplication ex…
2622d75 
…tensions (#834)"

This reverts commit 70a8d98.
@Jayxiang Jayxiang mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@Dan-Maor Dan-Maor Dan-Maor approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @KazuCocoa @Dan-Maor