fix: Support readonly arrays as event names #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rh389: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
This was referenced Oct 6, 2020
hwillson
force-pushed
the
fix/readonly-subscription-topics
branch
from
74470fd to
9b36315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING Allow a
readonlytopics / events array to be passed toPubSubEngine.asyncIterator(). I think this is how any well-behaved implementation should treat the incoming array anyway, and it would allow read-only arrays to be accepted upstream (eg MichalLytek/type-graphql#718)I believe this is (minor) breaking because it could mean downstream subclasses of
PubSubEnginere-implementasyncIteratorwith incompatible types. It might be best paired with #232 ?