Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow readonly string[] for Subscription topics #718

Closed
wants to merge 2 commits into from

Conversation

robhogan
Copy link

@robhogan robhogan commented Oct 6, 2020

I just ran into this while attempting to pass something like ['Topic1', 'Topic2'] as const to subscription options - there's no reason to restrict to mutable arrays here.

Copy link
Owner

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to reproduce the error in tests, push the failing commit and then after CI fail push the fixing commit.

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request labels Oct 6, 2020
@robhogan
Copy link
Author

robhogan commented Oct 6, 2020

Ach, looks like the issue starts upstream in graphql-subscriptions, (apollographql/graphql-subscriptions#234) where the change would be breaking.

Thanks for the quick response anyway, closing.

@robhogan robhogan closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants