Add inclusion conditions to generated Fragment Accessors #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
approved these changes
Jun 14, 2022
AnthonyMDev
added a commit
that referenced
this pull request
Jun 14, 2022
* Create base API for cache writes * WIP: Writing test for cache mutations * Make DataDict mutable * WIP: Cache Mutation Tests * Remove mock mutable selection set * Add _modify to DataDict * Fixed some more tests * Re-add MockMutableRootSelectionSet as protocol instead of class * JSONDecodingError Equatable * Test deletion of referenced record throws error * Add default __typename get/setter to MutableRootSelectionSet * Test for adding new entity reference to cache mutation * Finished ReadWriteFromStoreTests Refactor * Fix StoreConcurrencyTests * Fix WatchQueryTests * Fix SQLIteCacheTests * Add other operations and fragments to supported locations for cache mutation directive * Add operationType to LocalCacheMutation * Create LocalCacheMutationDefinitionTemplate and break out shared code from OperationDefinitionTemplate * Make MutableSelectionSet conform to SelectionSet * Generate SelectionSet Mutable TypeName * Generate mutable field accessors * WIP * Generate Named Fragment getter and setter * Finish generation of mutable selection sets * Generate Mutable Fragments * Compile directives on FragmentDefinition * Improve __typename addition functionality in frontend * Pretty print actual rendered on template test failure * Strip local cache mutation directive from source definition * Fix bug where __typename was added to inline fragments in Frontend * Make Fragment definition generate selection set as mutable for local cache mutations * Generate Local Cache Mutations into separate folder * Add inclusion conditions to generated Fragment Accessors (#2312) * Add resolution of inclusion conditions for conditional fragment conversion * Generate inclusion conditions on Fragment Gettters * Test * Add Mutable Typealiases to generated Schema. Clean up * Fixes for code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2310