Generate local cache mutations #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utation directive
… from OperationDefinitionTemplate
# Conflicts: # Apollo.xcodeproj/project.pbxproj # Sources/ApolloAPI/LocalCacheMutation.swift
# Conflicts: # Sources/ApolloAPI/LocalCacheMutation.swift
✅ Deploy Preview for apollo-ios-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AnthonyMDev
force-pushed
the
1.0/generate-local-mutations
branch
from
dfec4ec to
865de2a
Compare
There was a problem hiding this comment.
I had a comment re. this in one of the TS test files but we need to consider the implication of stripping things from the query string on Operation Safelisting. I feel like it may force us to implement the safelisting logic in apollo-ios because our client is the only one that would understand the local-only directives.
Sources/ApolloCodegenLib/Frontend/JavaScript/src/__tests__/sourceDefinitionTransformTests.ts
Show resolved
Hide resolved
Sources/ApolloCodegenLib/Templates/LocalCacheMutationDefinitionTemplate.swift
Outdated
Show resolved
Hide resolved
Tests/ApolloCodegenTests/CodeGeneration/FileGenerators/FragmentFileGeneratorTests.swift
Outdated
Show resolved
Hide resolved
Tests/ApolloCodegenTests/CodeGeneration/Templates/OperationDefinitionTemplateTests.swift
Show resolved
Hide resolved
AnthonyMDev
force-pushed
the
1.0/generate-local-mutations
branch
from
5d040a8 to
0be4705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Local Cache Mutation Templates!
Also needed to strip the
@apollo_client_ios_localCacheMutationdirective from the definition we send in the network request. While doing that, I did some clean up to the code that adds the__typenamefield. This way we just make one pass to convert the client definition into one suitable for sending to the server. Also added tests for that!