Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the performance issue when calling getHostName #2152

Merged
merged 1 commit into from
Apr 21, 2019
Merged

fix the performance issue when calling getHostName #2152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,16 @@ public InetAddress findValidateIp(List<InetAddress> addresses) {
weight += 2;
}

/**
* The following logic is removed as we will sort the network interfaces according to the index asc to determine
* the priorities between network interfaces, see https://github.com/ctripcorp/apollo/pull/1986
*/
// has host name
// TODO fix performance issue when calling getHostName
/*
if (!Objects.equals(address.getHostName(), address.getHostAddress())) {
weight += 1;
}
*/

if (weight > maxWeight) {
maxWeight = weight;
Expand Down