Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the performance issue when calling getHostName #2152

Merged
merged 1 commit into from
Apr 21, 2019

Conversation

nobodyiam
Copy link
Member

see #1986

@codecov-io
Copy link

Codecov Report

Merging #2152 into master will increase coverage by 7.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2152      +/-   ##
============================================
+ Coverage     49.97%   57.51%   +7.54%     
+ Complexity     1980     1120     -860     
============================================
  Files           401      193     -208     
  Lines         12403     5922    -6481     
  Branches       1276      636     -640     
============================================
- Hits           6198     3406    -2792     
+ Misses         5761     2257    -3504     
+ Partials        444      259     -185
Impacted Files Coverage Δ Complexity Δ
.../foundation/internals/NetworkInterfaceManager.java 61.01% <ø> (+0.36%) 11 <0> (ø) ⬇️
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
...rk/apollo/portal/service/NamespaceLockService.java
...k/apollo/portal/spi/ctrip/CtripUserInfoHolder.java
... and 200 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1164038...d1d6dbe. Read the comment docs.

@nobodyiam nobodyiam merged commit ea60157 into apolloconfig:master Apr 21, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants