Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiple-auth): improvements in multiple auth implementation #48

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

sufyankhanrao
Copy link
Collaborator

What

This PR adds improvements in the implementation of multiple authentication schemes. The improvements include the addition of auth-validation exception type which is to be raised when auth validation fails and the early returning of flow in case of OR authentication group. The changes also contain some refactoring of the code.

Why

  1. To fix a logical problem with the OR authentcation group
  2. To add a custom exception for auth validation for enhancing the developer experience

closes #47

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit adds improvements in the implementation of multiple authentication schemes. The improvements include the addition of auth-validation exception type and early returning in case of OR authentication group.

closes #47
@sufyankhanrao sufyankhanrao added the enhancement New feature or request label Dec 7, 2023
@sufyankhanrao sufyankhanrao self-assigned this Dec 7, 2023
Copy link
Contributor

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sufyankhanrao sufyankhanrao merged commit 9343356 into main Dec 8, 2023
6 checks passed
@sufyankhanrao sufyankhanrao deleted the 47-multiple-auth-improvements branch December 8, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve multiple authentication support
2 participants