Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multiple authentication support #47

Closed
asadali214 opened this issue Dec 7, 2023 · 0 comments · Fixed by #48
Closed

Improve multiple authentication support #47

asadali214 opened this issue Dec 7, 2023 · 0 comments · Fixed by #48
Assignees
@sufyankhanrao
Labels
enhancement New feature or request

Comments

@asadali214
Copy link
Contributor

asadali214 commented Dec 7, 2023 •
edited
Loading

We require the following enhancements in the multiple authentication feature:

  • Throw validation exception named AuthValidationException if any required auth parameter is missing or undefined
  • Verify the OR auth group implementation, we need to apply only the first available authentication scheme for OR auth groups instead of selecting all of auth schemes
  • Add unit tests to cover the AuthValidationException and new logical changes to the apply_auth function
@asadali214 asadali214 added the enhancement New feature or request label Dec 7, 2023
sufyankhanrao added a commit that referenced this issue Dec 7, 2023
@sufyankhanrao
feat(multiple-auth): improvements in multiple auth implementation
8c662fe 
This commit adds improvements in the implementation of multiple authentication schemes. The improvements include the addition of auth-validation exception type and early returning in case of OR authentication group.

closes #47
@sufyankhanrao sufyankhanrao mentioned this issue Dec 7, 2023
Merged
12 tasks
sufyankhanrao added a commit that referenced this issue Dec 8, 2023
@sufyankhanrao
feat(multiple-auth): improvements in multiple auth implementation (#48)
9343356 
This commit adds improvements in the implementation of multiple authentication schemes. The improvements include the addition of auth-validation exception type and early returning in case of OR authentication group.

closes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sufyankhanrao sufyankhanrao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(multiple-auth): improvements in multiple auth implementation apimatic/core-lib-python
2 participants
@sufyankhanrao @asadali214