[#408] Fix team lists cache errors. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr576
suggested changes
Jun 5, 2020
modules/apigee_edge_teams/src/Entity/ListBuilder/TeamListBuilder.php
Outdated
Show resolved
Hide resolved
modules/apigee_edge_teams/src/Entity/ListBuilder/TeamListBuilder.php
Outdated
Show resolved
Hide resolved
|
This also needs test coverage. |
mxr576
suggested changes
Jun 8, 2020
modules/apigee_edge_teams/src/Entity/ListBuilder/TeamListBuilder.php
Outdated
Show resolved
Hide resolved
mxr576
reviewed
Jun 8, 2020
arlina-espinoza
force-pushed
the
408-teams-list-caching
branch
from
15c1eb4 to
1a1f187
Compare
|
This is ready for another review - failing tests will be fixed once #426 is in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the caching issue reported on #408 by adding the current user to the render array context and cache tags.