-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status of the App is not updated immediately on the App list #430
Comments
Drupal does not handle if an entity can be edited outside of Drupal's database. Also, it seems entity list builders were being built for admin purposes and not for end-users. When an entity gets updated in Drupal, the This is not enough here. We have an app cache that controls how long we should not ask Apigee Edge for changes basically. This is basically a cache max age for all places where an app is being rendered and it works on the app view, but not on the list pages, because Drupal's entity listing pages does not calculate with cache data related to listed entities. We have a calculated "App state" rendered on the list builder and the render array should contain all cache data from the related app entity, including max-age. My guess that this could be an issue on other entity listing pages, not just on apps. A simple fix could be added the configured cache timeout to entity listing pages too. |
Yeah, I also think that potentially all list builders might not be respecting the cache expiring time set in their respective apigee settings, not just for apps. We could add a |
@arlina-espinoza Are we adding the |
* [#432] Implement credential deletion and generation * [#432] Add operations links and expiration date * [#432] Add tests * [#432] Implement routes for Team App * [#430] Refactor to a trait * [#432] Lock rules version * [#432] Fix rules version * [#430] Fix remove product event test * [#432] Remove approve operation * [#432] Update credential form to use most recently active one * [#432] Update tests * [#432] Fix phpcs notices * [#432] Make add key form use modal * [#432] Rename credential to api keys * [#432] Fix conflicts * [#432] Fix merge conflicts * [#432] Update selector for dropbutton * [#432] Revert php change * [#432] Do not show warning for revoked credentials * [#432] Skip api key routes for permission tests * [#432] Implement api keys permissions * [#432] Add tests for expired credentials warning * [#432] Remove update access check * [#432] Hide revoke credentials in collapsible section * [#432] Fix tests * [#432] Add api key routes permission tests * [#432] Add add_api_key to permission matrix * [#432] Update route for team test * [#432] Prevent revoking/deleting the only active key * [#432] Fix tests for new permission * [#432] Use machine name * [#432] Clean up developer and developerApp in tear down * [#432] Add permission for editing API products * [#432] Assign default permissions * [#432] Update test permissions * Fix credentials show/hide functionality issue when it gets revoked. * Add revoke_api_key permission to authenticated users * Remove add_keys from under content * [#432] Add "edit_api_products" to authenticated user default permissions. * [#432] Fix DeveloperAppApiKeysPermissionTest for integration and mock tests. * [#432] Fix DeveloperAppApiKeyTest for integration and mock tests. Co-authored-by: Minnur Yunusov <[email protected]> Co-authored-by: Arlina Espinoza <[email protected]>
Description
When someone logs in as an authenticated user (not admin) into a site, and changes the status of an App's product in Apigee Edge's UI, the status will not change on the App list as well. Meanwhile, it's refreshed on the App's page itself.
This might be confusing for a user.
For a user who is logged in to the site as an administrator, this works as intended.
None of the cache settings (API Product caching or Developer App settings cache) affects the outcome.
Steps to Reproduce
Steps to reproduce the behavior:
Actual Behavior
The status in the App list remains unchanged, whilst if you click on the App's name and go to the App page itself, the status is changed. The status on the App list will only change if a global cache rebuild is applied.
Expected Behavior
Change the status of the App on the App list as well.
Screenshots
On the App list: https://i.imgur.com/ndKIA69.png (status is not changed)
On the App's page: https://i.imgur.com/mmpWq5A.png (status is changed)
Version Info
Apigee Edge Drupal integration Module 8.x-1.7, Drupal core 8.8.6
The text was updated successfully, but these errors were encountered: