Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#409] Update UI for API keys #416

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented Aug 24, 2020

Fixes #409

apigee-kickstart-api-keys-ui

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Aug 24, 2020
@shadcn shadcn requested a review from arlina-espinoza August 24, 2020 08:10
Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once apigee/apigee-edge-drupal#446 is merged. Thanks @arshad

@arlina-espinoza arlina-espinoza modified the milestone: 8.x-1.20 Aug 27, 2020
@shadcn
Copy link
Contributor Author

shadcn commented Aug 28, 2020

@arlina-espinoza apigee/apigee-edge-drupal#446 is ready for review too.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Sep 8, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Sep 8, 2020
@shadcn shadcn merged commit e610416 into apigee:8.x-1.x Sep 8, 2020
shadcn pushed a commit to shadcn/apigee-devportal-kickstart-drupal that referenced this pull request Sep 24, 2020
)

* [apigee#416] New endpoint to get credentials via Ajax calls.

* New endpoint to get credentials via Ajax calls.

* [apigee#416] Update endpoints, bump apigee_edge to 8.x-1.13

Co-authored-by: Arlina Espinoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI/theme for API Keys
3 participants