Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#416] New endpoint to get credentials via Ajax calls. #387

Merged

Conversation

minnur
Copy link
Contributor

@minnur minnur commented Jul 6, 2020

This one is related to this apigee/apigee-edge-drupal#434

because show/hide credentials functionality altered in the kickstarter I had to make the change here as well.

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Jul 6, 2020
@minnur
Copy link
Contributor Author

minnur commented Jul 6, 2020

Important: This should not be merged before this apigee/apigee-edge-drupal#434

@arlina-espinoza
Copy link
Contributor

@minnur Please see the comment about changes requested in apigee/apigee-edge-drupal#434 (review) to do access checking on the credentials endpoint. If implemented, this PR needs to be updated too.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Aug 4, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Aug 4, 2020
@arlina-espinoza
Copy link
Contributor

Added bumping the required apigee_edge version to 8.x-1.13 because this should be merged and released after apigee/apigee-edge-drupal#457 is released (on 8.x-1.13).

Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but holding off merging until apigee_edge 8.x-1.13 is released.

@arlina-espinoza arlina-espinoza added this to the 8.x-1.18 milestone Aug 5, 2020
@arlina-espinoza arlina-espinoza merged commit b6a48d4 into apigee:8.x-1.x Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants