-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#416] New endpoint to get credentials via Ajax calls. #387
[#416] New endpoint to get credentials via Ajax calls. #387
Conversation
Important: This should not be merged before this apigee/apigee-edge-drupal#434 |
@minnur Please see the comment about changes requested in apigee/apigee-edge-drupal#434 (review) to do access checking on the credentials endpoint. If implemented, this PR needs to be updated too. |
…int-toggle-password
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Added bumping the required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but holding off merging until apigee_edge 8.x-1.13 is released.
This one is related to this apigee/apigee-edge-drupal#434
because show/hide credentials functionality altered in the kickstarter I had to make the change here as well.