Fix extend element #247
Fix extend element #247
Conversation
Add ability to corectly handle complex types for nested types type definition like `- type (array[Comlex, Types])` Correctly handle deeper dependencies in registry for nested types definition
Registaration of NamedTypes now happens in "two steps" - create and registrate empty refract element with correct type info - create element with complex info (meta/attrs/content) This solution will allow knowledge correct type info of referenced element, so later while element is expanded we will receive correct base element type for extend element merging Additional changes: - Extract RefractElementFactory into file
| std::cout << "==BASE TYPE ORDER==" << std::endl; | ||
| #endif /* DEBUG_DEPENDENCIES */ | ||
|
|
||
| #if 1 |
|
❤️ |
| "attributes": { | ||
| "contentType": "application/schema+json" | ||
| }, | ||
| "content": "{\n \"$schema\": \"http://json-schema.org/draft-04/schema#\",\n \"type\": \"object\",\n \"properties\": {\n \"loc\": {}\n }\n}" |
There was a problem hiding this comment.
Schema is incorrect it should be an array, it probably is a bug and should be a separate fix
There was a problem hiding this comment.
@w-vi Can you please create an issue so we don't forget this? Thanks.
|
@klokane @pksunkara Apart from the test comments I think it's good to go |
|
Ok, so I will cut |
Cleanup forgoted `#ifdef`
klokane
force-pushed
the
klokane/fix-extend-element
branch
from
2332d02 to
d6e34c6
Compare
|
Updated |
|
@pksunkara If you have nothing more to add please merge as I'm cool with the current state |
| using namespace refract; | ||
| using namespace drafter; | ||
|
|
||
| TEST_CASE("Create empty primitive element","[ElementFactory]") { |
There was a problem hiding this comment.
Shouldn't the { be in new lines for the tests?
There was a problem hiding this comment.
There are in test-ApplyVisitorTest.cc in same position.
But we should finally create clang-format config and add into repo
|
Reviewed. |
|
@pksunkara can you please do ALL STYLE RELATED comments in one "turn" |
|
@klokane Sorry, But I do the style comments when I go through the code. :( |
|
Again style discussion, please @pksunkara have a look at apiaryio/snowcrash#360 and give it a try so we can start using it |
This patch fix recent issues around "ExtendElement"
Fix #217 #245
This solution will allow knowledge correct type info of referenced
element, so later while element is expanded we will receive correct
base element type for extend element merging
- type (array[Comlex, Types])