Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Style matters, style is everything! #360

Closed
w-vi opened this issue Dec 16, 2015 · 7 comments
Closed

Style matters, style is everything! #360

w-vi opened this issue Dec 16, 2015 · 7 comments
Assignees

Comments

@w-vi
Copy link
Contributor

w-vi commented Dec 16, 2015

Proposal of a clang-format style definition for all the C++ tools and libs in the API Blueprint ecosystem.
To make it easier for everybody, no more whitespace or whatever style discussions. Give it a try, see if you like it and propose changes.

https://gist.github.com/w-vi/bad74be461b3181f24e1

@w-vi
Copy link
Contributor Author

w-vi commented Jan 24, 2016

@pksunkara have had a chance to look at it?

@pksunkara
Copy link
Contributor

  • AlwaysBreakBeforeMultilineStrings should probably be true
  • BinPackArguments and BinPackParameters should probably be false
  • SpaceAfterCStyleCast should be true. Better readability

@w-vi Done.

@w-vi
Copy link
Contributor Author

w-vi commented Mar 21, 2016

Agree with all but SpaceAftertCStyleCast.

(void *)pObj looks to me more clear than (void *) pObj

what others like @klokane think? I'll accept it both ways but let the majority decide

@klokane
Copy link
Contributor

klokane commented Mar 21, 2016

Agree with @w-vi casting with space is feeling "loose context"
Additionaly it should not be used in C++ much better and clear is use casting operators

@pksunkara
Copy link
Contributor

Okay. Let's do this.

@w-vi
Copy link
Contributor Author

w-vi commented Apr 4, 2016

Gist updated

@kylef
Copy link
Member

kylef commented Aug 22, 2017

This has been completed in #380.

@kylef kylef closed this as completed Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants