Add info airnode-deployer command
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
Sep 27, 2022
| const goDeploymentInfo = await go(() => deploymentInfo(args.deploymentId as string)); | ||
| if (!goDeploymentInfo.success) { | ||
| // eslint-disable-next-line functional/immutable-data | ||
| process.exitCode = 1; |
There was a problem hiding this comment.
Isn't this too harsh? Will there be a message logged out?
There was a problem hiding this comment.
Yes, there will be https://github.com/api3dao/airnode/blob/deployment-info/packages/airnode-deployer/src/infrastructure/index.ts#L694
I think it should end up with the non-zero exit code when it can't find the deployment. It's the same thing as when you call docker inspect <ID> with an invalid/non-existent ID.
| consoleLog(`Airnode version: ${airnodeVersion}`); | ||
| consoleLog(`Deployment ID: ${id}`); | ||
| const tableString = table.toString(); | ||
| const tableStringWithCurrent = tableString.replace(new RegExp(`(?<=${currentVersionId}.*?)\n`), ' (current)\n'); |
Siegrift
approved these changes
Sep 29, 2022
amarthadan
force-pushed
the
temp-v0.10.0
branch
from
2b27315 to
522c5e2
Compare
amarthadan
force-pushed
the
deployment-info
branch
from
2a78011 to
f32cdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1404
As I noted in the code, there will be some refactoring once #1473 is done (or rather as part of that)