Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to retrieve info about their deployments #1404

Closed
Tracked by #1605
amarthadan opened this issue Aug 29, 2022 · 6 comments · Fixed by #1477
Closed
Tracked by #1605

Allow users to retrieve info about their deployments #1404

amarthadan opened this issue Aug 29, 2022 · 6 comments · Fixed by #1477

Comments

@amarthadan
Copy link
Contributor

amarthadan commented Aug 29, 2022

Allow users to see info and history of changes for a specific deployment.

airnode-deployer info 40207f25

Cloud provider: AWS (us-east-1)
Airnode address: 0xd0624E6C2C8A1DaEdE9Fa7E9C409167ed5F256c6
Stage: dev
Airnode version 0.9.0
┌────────────┬───────────────────────────┐
│ Version ID │ Deployment time           │
├────────────┼───────────────────────────┤
│ 5bbcd317   │ 2022-08-29 09:12:34 GMT+2 │
├────────────┼───────────────────────────┤
│ 21f1b492   │ 2022-09-29 07:34:33 GMT+2 │
├────────────┼───────────────────────────┤
│ 2c8b8bbe   │ 2022-08-12 10:17:09 GMT+2 │
└────────────┴───────────────────────────┘

Based on the deployment ID from the list command (#1403).
The version ID will be constructed as the first 8 characters of sha([cloudProvider, region, airnodeAddress, stage, airnodeVersion, deploymentTime]) so it's unique for the deployment and its historical version.

Basically a preparation for #1406

@aquarat aquarat changed the title Allow users to inquire an info about their deployments Allow users to retrieve info about their deployments Sep 13, 2022
@aquarat aquarat added this to the 0.11.0 milestone Sep 13, 2022
@aTeoke aTeoke modified the milestones: 0.11.0, 0.10.0 Sep 21, 2022
@amarthadan amarthadan self-assigned this Sep 23, 2022
@amarthadan
Copy link
Contributor Author

@bbenligiray @aquarat I've updated the description, let me know if you're ok with this.

@Siegrift
Copy link
Contributor

Maybe:

Cloud provider: AWS (us-east-1)
Airnode address: 0xd0624E6C2C8A1DaEdE9Fa7E9C409167ed5F256c6
Stage: dev
Airnode version 0.9.0
┌────────────┬───────────────────────────┐
│ Version ID │ Deployment time           │
├────────────┼───────────────────────────┤
│ 5bbcd317   │ 2022-08-29 09:12:34 GMT+2 │ (current)
├────────────┼───────────────────────────┤
│ 21f1b492   │ 2022-09-29 07:34:33 GMT+2 │
├────────────┼───────────────────────────┤
│ 2c8b8bbe   │ 2022-08-12 10:17:09 GMT+2 │
└────────────┴───────────────────────────┘

@Siegrift
Copy link
Contributor

This info command will only show Airnodes deployed with the current Airnode version. Correct me if I am wrong, but this means that the user will first have to remove all of these (which will remove the files in AWS) and then redeploy with a new deployer version.

@amarthadan
Copy link
Contributor Author

The (current) is a nice touch. But the table is generated by a library 😅 I'll figure something out 😄

This info command will only show Airnodes deployed with the current Airnode version. Correct me if I am wrong, but this means that the user will first have to remove all of these (which will remove the files in AWS) and then redeploy with a new deployer version.

I think there's some confusion. This is info about one deployment. The dates are the dates of previous "versions" of the same deployment (e.g. updated config.json). It's basically just preparation for #1406.
But yes, if you would want to upgrade the Airnode version you would have to remove this one deployment and deploy the new version. But that's just one remove-with-receipt/remove-with-deployment-details command.

@bbenligiray
Copy link
Member

I like it. "(current)" or something to that effect would be good.

@martinkolenic
Copy link
Contributor

I tested this for both AWS and GCP. I tested with no redeployment, one, and two. The (current) indicator always pointed at the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants