Handle deprecations from Symfony 5.1 #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/symfony-5.1-deprecations
branch
from
d2cd906 to
c163d51
Compare
derrabus
commented
May 31, 2020
| @@ -18,7 +18,6 @@ | |||
| <service id="api_platform.operation_method_resolver" class="ApiPlatform\Core\Bridge\Symfony\Routing\OperationMethodResolver" public="false"> | |||
| <argument type="service" id="api_platform.router" /> | |||
| <argument type="service" id="api_platform.metadata.resource.metadata_factory" /> | |||
| <deprecated>The "%service_id%" service is deprecated since API Platform 2.5.</deprecated> | |||
There was a problem hiding this comment.
💡 I haven't found a way to produce an XML file that can be loaded with DependencyInjection 4.4 and 5.1 without errors:
- DI 5.1 triggers a deprecation if the attributes
packageandversionare missing. - DI 4.4 throws an exception, if those attributes are present.
This is why I'm deprecating the services inside the extension now.
derrabus
force-pushed
the
bugfix/symfony-5.1-deprecations
branch
from
c163d51 to
592dede
Compare
alanpoulain
force-pushed
the
bugfix/symfony-5.1-deprecations
branch
from
592dede to
e8749d5
Compare
alanpoulain
approved these changes
Jun 4, 2020
|
Thank you very much @derrabus! |
|
Hi everyone, I still get the error with api-platform/core v2.5.6. Do you know why could it be? |
|
Cause this was not yet released: v2.5.6...2.5 |
|
Oh sorry, i don't know why i thought that because it is merged is released... Thank you @stloyd !! |
|
Summer and holidays are making things to move at slow pace, bear with us :) |
|
When do you plan to release it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses method signatures of the Symfony Config and DependencyInjection components that have changed in Symfony 5.1.