Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting deprecated services properly #3595

Closed
NicoHaase opened this issue Jun 4, 2020 · 1 comment
Closed

Setting deprecated services properly #3595

NicoHaase opened this issue Jun 4, 2020 · 1 comment

Comments

@NicoHaase
Copy link
Contributor

API Platform version(s) affected: api-platform/core v2.5.6

Description
Symfony 5.1 has been released last week, and it's deprecation handling has changed a bit. According to symfony/symfony@f10413c, you need to use not only the deprecated tag in src/Bridge/Symfony/Bundle/Resources/config/api.xml, but also provide the package name and the version number in which the deprecation has been introduced.

How to reproduce
Start a new project based on Symfony 5.1 and API Platform

Possible Solution
Change each occurence of a deprecated tag to something like

<deprecated package="api-platform/core" version="2.5">The "%service_id%" service is deprecated since API Platform 2.5.</deprecated>
@alanpoulain
Copy link
Member

Hello.
There is already a PR to fix this deprecation: #3589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants