-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pcap replay #132
Conversation
Hi @eddc005 thanks for your PR. It just so happens that I'm also changing the packet part... Can you update your code to match the latest interface? |
Also, I'm not sure why |
Certainly! Ah you are right I'll remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the following two changes
Updated! Hopefully I understand Appreciate a lot for your review! I'm fairly new to networking programming in Go. Forgive me for making obvious mistakes sometimes. |
Merged, thanks again :) |
I have reverted the changes. We need to find a way to not rely on CGO - the current pcap implementation in gopacket requires CGO |
Description
Completes #122. Added support for pcap replay. Implementation based on the prototype posted in the issue (Thanks to @66hh)
Introduced a new command line argument
Added a new configuration block for pcap replay
Implementation