Skip to content

Commit

Permalink
Merge pull request #133 from apernet/fix-timestamp
Browse files Browse the repository at this point in the history
fix: provide correct timestamp for TCP reassembler
  • Loading branch information
tobyxdd authored May 6, 2024
2 parents 245ac46 + d750626 commit 5723490
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
4 changes: 3 additions & 1 deletion engine/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,11 @@ func (e *engine) dispatch(p io.Packet) bool {
_ = e.io.SetVerdict(p, io.VerdictAcceptStream, nil)
return true
}
// Convert to gopacket.Packet
packet := gopacket.NewPacket(data, layerType, gopacket.DecodeOptions{Lazy: true, NoCopy: true})
packet.Metadata().Timestamp = p.Timestamp()
// Load balance by stream ID
index := p.StreamID() % uint32(len(e.workers))
packet := gopacket.NewPacket(data, layerType, gopacket.DecodeOptions{Lazy: true, NoCopy: true})
e.workers[index].Feed(&workerPacket{
StreamID: p.StreamID(),
Packet: packet,
Expand Down
3 changes: 3 additions & 0 deletions io/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package io
import (
"context"
"net"
"time"
)

type Verdict int
Expand All @@ -24,6 +25,8 @@ const (
type Packet interface {
// StreamID is the ID of the stream the packet belongs to.
StreamID() uint32
// Timestamp is the time the packet was received.
Timestamp() time.Time
// Data is the raw packet data, starting with the IP header.
Data() []byte
}
Expand Down
18 changes: 15 additions & 3 deletions io/nfqueue.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"strconv"
"strings"
"syscall"
"time"

"github.com/coreos/go-iptables/iptables"
"github.com/florianl/go-nfqueue"
Expand Down Expand Up @@ -189,6 +190,12 @@ func (n *nfqueuePacketIO) Register(ctx context.Context, cb PacketCallback) error
streamID: ctIDFromCtBytes(*a.Ct),
data: *a.Payload,
}
// Use timestamp from attribute if available, otherwise use current time as fallback
if a.Timestamp != nil {
p.timestamp = *a.Timestamp
} else {
p.timestamp = time.Now()
}
return okBoolToInt(cb(p, nil))
},
func(e error) int {
Expand Down Expand Up @@ -312,15 +319,20 @@ func (n *nfqueuePacketIO) setupIpt(local, rst, remove bool) error {
var _ Packet = (*nfqueuePacket)(nil)

type nfqueuePacket struct {
id uint32
streamID uint32
data []byte
id uint32
streamID uint32
timestamp time.Time
data []byte
}

func (p *nfqueuePacket) StreamID() uint32 {
return p.streamID
}

func (p *nfqueuePacket) Timestamp() time.Time {
return p.timestamp
}

func (p *nfqueuePacket) Data() []byte {
return p.data
}
Expand Down

0 comments on commit 5723490

Please sign in to comment.