Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#8273): dashboard filter for table #8277

Closed
wants to merge 2 commits into from
Closed

fix(#8273): dashboard filter for table #8277

wants to merge 2 commits into from

Conversation

cmyip
Copy link

@cmyip cmyip commented Sep 22, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Used in conjunction with PR apache-superset/superset-ui-plugin#206

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TableFilter

TEST PLAN

Select and deselect a table

ADDITIONAL INFORMATION

Fixes #8273 and apache-superset/superset-ui-plugins#125

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
We don't have this case (table filter) from our users. Do you mind adding a unit test?
Also I am building a new feature called scoped filter, which is to allow dashboard owner set the charts that the filter will apply on. For example, a filter can only apply to a single tab instead of whole dashboard. I will only handle filter_box filter in the new feature (current WIP: https://github.com/apache/incubator-superset/compare/master...graceguo-supercat:scoped-filters-v2?expand=1). Do you want to extend it to table filters as well?

@stale
Copy link

stale bot commented Nov 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Nov 22, 2019
@stale stale bot closed this Nov 29, 2019
@lilila
Copy link

lilila commented Mar 21, 2020

It would be nice if table filter were added

@timalive
Copy link

Hi - has there been any movement on this issue? Not clear what the path is for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table filter not working
4 participants